rollbar / pyrollbar

Error tracking and logging from Python to Rollbar
https://docs.rollbar.com/docs/python/
MIT License
213 stars 133 forks source link

Fix walk_trace_chain: change container for seen_exceptions #411

Open Safintim opened 1 year ago

Safintim commented 1 year ago

Description of the change

What if, for some reason, the exception is not hashable?

I ran into this problem using the library https://github.com/ecederstrand/exchangelib Here's my pr https://github.com/ecederstrand/exchangelib/pull/1097

I don't know why the author decided to do that. Asked the author, haven't received an answer yet. Anyway, it seems to me that it's worth providing for such a possibility.

Type of change

Checklists

Development

Code review