Replace `httpx.post` `data` kwarg with `content` - Githubissues

rollbar / pyrollbar

Error tracking and logging from Python to Rollbar

https://docs.rollbar.com/docs/python/

MIT License

213 stars 135 forks source link

Replace `httpx.post` `data` kwarg with `content` #425

Closed ayharano closed 1 year ago

ayharano commented 1 year ago

Description of the change

As described in https://github.com/encode/httpx/blame/08a557e3e2b9220b90ee21238e316206ffa65d36/docs/compatibility.md?plain=1#L70-L90 the data parameter in httpx.post was intended to provide compatibility from requests, but as it does not provide anymore for this end, it issues a warning

DeprecationWarning: Use 'content=<...>' to upload raw bytes/text content.

when using pyrollbar is used with asyncio

Type of change

[X] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[ ] New release

Checklists

Development

[X] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[X] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer