custom is a better place for user provided extra_data, since custom is where users can put data interesting to them. However, custom is not to be filled by the SDK, so some SDK generated fields that are also filled using extra_data (in logger.py) should not be moved under custom.
Type of change
[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[ ] New release
Related issues
Shortcut stories and GitHub issues (delete irrelevant)
Fix [SC-127161]
Checklists
Development
[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
Code review
[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[x] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer
Description of the change
custom
is a better place for user providedextra_data
, sincecustom
is where users can put data interesting to them. However,custom
is not to be filled by the SDK, so some SDK generated fields that are also filled usingextra_data
(inlogger.py
) should not be moved undercustom
.Type of change
Related issues
Checklists
Development
Code review