Objective-C & Swift library for remote crash, exception, error reporting, and logging with Rollbar. It works on all Apple *OS platforms (macOS, iOS, tvOS, watchOS, etc).
This PR renames RollbarCrashReportTests to RollbarReportTests to follow the new module schema post-KSCrash integration where RollbarCrashReport is now known as RollbarReport and our crash monitoring and recording module as RollbarCrash.
This PR also cleans up some unused testing xcschemes.
It seems the RollbarReport tests weren't being run by the CI, part of the cleanup of schemes included making RollbarReport part of the RollbarNotifierxcscheme and removing the separate RollbarCrashReport scheme. This seem to have inadvertently fix the issue and running these tests from the CI uncovered a minor issue in the way we were writing crash reports, where we were using the current time zone instead of GMT.
This has been fixed in this PR, too.
Type of change
[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Maintenance
[ ] New release
Checklists
Development
[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
Code review
[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] "Ready for review" label attached to the PR and reviewers assigned
[x] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer
Description of the change
This PR renames
RollbarCrashReportTeststoRollbarReportTeststo follow the new module schema post-KSCrashintegration whereRollbarCrashReportis now known asRollbarReportand our crash monitoring and recording module asRollbarCrash.This PR also cleans up some unused testing
xcschemes.It seems the
RollbarReporttests weren't being run by the CI, part of the cleanup of schemes included makingRollbarReportpart of theRollbarNotifierxcschemeand removing the separateRollbarCrashReportscheme. This seem to have inadvertently fix the issue and running these tests from the CI uncovered a minor issue in the way we were writing crash reports, where we were using the current time zone instead of GMT.This has been fixed in this PR, too.
Type of change
Checklists
Development
Code review