search

rollbar / rollbar-flutter

Rollbar for Dart and Flutter
https://docs.rollbar.com/docs/flutter
MIT License
21 stars 31 forks source link

v1.5.0 (latest) no longer works on Xcode 18 #136

Open timothyrobb opened 2 months ago

timothyrobb commented 2 months ago

Using the latest released version of Xcode, v18, and using the latest version of rollbar_flutter, v1.5.0, we get compiler errors.

/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:66:13: error: no type named 'terminate_handler' in namespace 'std'
    66 | static std::terminate_handler g_originalTerminateHandler;
      |        ~~~~~^
/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:219:47: error: no member named 'set_terminate' in namespace 'std'
  219 |             g_originalTerminateHandler = std::set_terminate(CPPExceptionTerminate);
      |                                          ~~~~~^
/<project_dir>/ios/Pods/RollbarCrash/RollbarNotifier/Sources/RollbarCrash/Monitors/RollbarCrashMonitor_CPPException.cpp:223:18: error: no type named 'set_terminate' in namespace 'std'
  223 |             std::set_terminate(g_originalTerminateHandler);
      |             ~~~~~^
image

This makes the package and service entirely unusable for any project that uses the latest version of Xcode.

I know this package is barely maintained, if ever. But if this isn't patched shortly, you're going to find almost every user of this package disappearing over a few months and using another service entirely.

timothyrobb commented 2 months ago

It looks like this has been fixed in RollbarNotifier 3.3.2 https://github.com/rollbar/rollbar-apple/issues/348#issuecomment-2293887391

kevinconcourse commented 1 month ago

Hi, Any guide on how to fix this issue??

diegoalex commented 1 month ago

Same issue as @timothyrobb here. App stop building after update to XCode 18.

I've checked the code here and the version 1.5.0 still pointing to the old RollbarNotifier version

image
sonjz commented 3 weeks ago

It's been 14 months since the rollbar team updated pub.dev... that's a long time between platform versions:

I noticed some fixes on repo, and since this is technically still in beta, I'm targeting the repo directly in my pubspec.yml

dependencies:
...
  rollbar_flutter:
    git: 
      url: https://github.com/rollbar/rollbar-flutter.git
      ref: main
      path: rollbar_flutter/
...

Can we push this change, or anyone forked it yet?

sonjz commented 3 weeks ago

and ... shit.

from readme.

As of April 2024, Rollbar will not be actively updating this repository and plans to archive it. We encourage our community to fork this repo if you wish to continue its development. While Rollbar will no longer be engaging in active development, we remain committed to reviewing and merging pull requests, particularly those about security updates. If an actively maintained fork emerges, please let us know, and we will gladly link to it from our documentation.

sonjz commented 2 weeks ago

if anyone needs a fork, i updated code to handle RollbarNotifier and fixed the AndroidManifest.xml packageName/namespace issue for Android 15.

https://github.com/sonjz/rollbar-flutter/commit/265e9c9a49873e928a21c705660766d49cfdbbbc

add it to your pubspec.yaml with:

...
dependencies:
...
  rollbar_flutter:
    git: 
      url: https://github.com/sonjz/rollbar-flutter.git
      ref: main
      path: rollbar_flutter/
...

Hope this helps as a stopgap, but yup, project is dead... Crashalytics anyone?