rollbar / rollbar-flutter

Rollbar for Dart and Flutter
https://docs.rollbar.com/docs/flutter
MIT License
21 stars 27 forks source link

Removed unused UncaughtErrorHandler. #57

Closed matux closed 2 years ago

matux commented 2 years ago

Description of the change

After the recent changes, we've dropped UncaughtErrorHandler, this removes it.

Type of change

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

Code review

matux commented 2 years ago

LGTM. I assume the functionality of UncaughtErrorHandler was moved to another place/class?

It wasn't doing anything.

The error listening properties of the Isolate were being used incorrectly, so only errors happening within the isolate were being caught.

The other thing the UncaughtErrorHandler was doing was initializing RollbarInfrastructure, I don't know why it was there, and it was the reason why the lib wasn't sending payloads to Rollbar.

Now everything is initialized at a single point when Rollbar starts.

matux commented 2 years ago

LGTM. I assume the functionality of UncaughtErrorHandler was moved to another place/class?

All the details are in the issue I created: https://github.com/rollbar/rollbar-flutter/issues/45.