Removed connectivity monitor. - Githubissues

rollbar / rollbar-flutter

Rollbar for Dart and Flutter

https://docs.rollbar.com/docs/flutter

MIT License

21 stars 27 forks source link

Removed connectivity monitor. #69

Closed matux closed 2 years ago

matux commented 2 years ago

Description of the change

I'm removing ConnectivityMonitor for the following reasons:

Flutter already has a connectivity monitoring mechanism.
ConnectivityMonitor doesn't provide actual connectivity monitoring in neither rollbar_common nor rollbar_dart.
Our CM doesn't add any features over Flutter's existent implementation.
It's not used internally.
Less code to maintain.
YAGNI

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Maintenance
[ ] New release

Related issues

Fix https://github.com/rollbar/rollbar-flutter/issues/41

Checklists

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] "Ready for review" label attached to the PR and reviewers assigned
[x] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

matux commented 2 years ago

@akornich If you disagree, or I'm missing something, or would like to keep it, please do tell me!