search

rollbar / rollbar-gem

Exception tracking and logging from Ruby to Rollbar
https://docs.rollbar.com/docs/ruby
MIT License
446 stars 280 forks source link

I would like to add async engine name #1075

Open saiqulhaq opened 2 years ago

saiqulhaq commented 2 years ago

Hi Rollbar team

My team doesn't know that our Rollbar config uses Sidekiq for reporting, and the Sidekiq was not running on that time he was wondering why the report is not available on Rollbar so would you accept my PR if I add any async engine name into the following notifier class? https://github.com/rollbar/rollbar-gem/blob/9efecb9a8d10ca7e5df9355c0a7dfd3f269a452c/lib/rollbar/notifier.rb#L905

waltjones commented 2 years ago

@saiqulhaq Sounds like you'd just add the async engine name to the log string, if present? Yes, that would be an acceptable change, assuming the implementation doesn't have side effects.