rollbar / rollbar-java

Rollbar for Java and Android
https://docs.rollbar.com/docs/java
MIT License
71 stars 76 forks source link

Don't require an access token in log4j appender when configuration class is provided #261

Closed diegov closed 3 years ago

diegov commented 3 years ago

Description of the change

The configuration class can provide the access token, so we don't need it to be required as an appender parameter when a configuration class is configured.

This change will validate that either a configuration class or an access token is provided (both are also allowed), and will fail to initialise the appender only when neither is present.

Type of change

Related issues

None

Checklists

Development

Code review

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Clubhouse Story #79314: Rollbar Java Log4j2 integration requires an accessToken even when using configProviderClassNam.