fixed compatibility with Lumen 8.x without sessions - Githubissues

rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects

https://docs.rollbar.com/docs/laravel

140 stars 39 forks source link

fixed compatibility with Lumen 8.x without sessions #106

Closed gabrielslau closed 2 years ago

gabrielslau commented 3 years ago

Description of the change

this fix was originally proposed on issue https://github.com/rollbar/rollbar-php-laravel/issues/83 and PR https://github.com/rollbar/rollbar-php-laravel/pull/84 and https://github.com/rollbar/rollbar-php-laravel/pull/90 without further interaction/response from the original contributor.

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [#83](), [#84]() and [#90]()

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

bxsx commented 2 years ago

Hi @gabrielslau and thanks for bringing it up.

I've updated the conditional expression to use isset().