Fixed MonologHandler conflict while using rollbar agent

rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects

https://docs.rollbar.com/docs/laravel

140 stars 39 forks source link

Fixed MonologHandler conflict while using rollbar agent #108

Closed Lukasz93P closed 3 years ago

Lukasz93P commented 3 years ago

Description of the change

Resolver handler conflict while using rollbar agent handler. Bug which was describer here

Type of change

[x] Bug fix (non-breaking change that fixes an issue)

Related issues

Bug #85

Checklists

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

Lukasz93P commented 3 years ago

@bishopb @brianr @waltjones @jenssegers @ArturMoczulski can you please review and merge this change? I know that this is maybe not ideal but I'm in a hurry I need working laravel rollbar agent for my production app ASAP.

brianr commented 3 years ago

Hi @Lukasz93P, we will aim to get this reviewed soon, but probably not until next week. The fastest path to resolve your production app issue is probably to install your branch directly, something like this: https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository (note you'll probably need to rename the branch to start with dev-).

Lukasz93P commented 3 years ago

@brianr I know that but I didnt want to have to do this. Thanks for info when somebody will look at this 🙂

Lukasz93P commented 3 years ago

@brianr can someone review this pr ?

BTW I figured out that renaming branch is not necessary, now I have dev-dev ;) because dev prefix is not part of the branch name.

bishopb commented 3 years ago

Thanks for the contribution, @Lukasz93P. I've taken this in a slightly different direction. Would you mind trying Pull Request #109 in your environment to see if it works for you?

Lukasz93P commented 3 years ago

@bishopb yes, I will try but I need at least few days for this.

bishopb commented 3 years ago

Thank you again for your contribution. I'm closing this one in favor of Pull Request #109. A new release will be cut soon.

Lukasz93P commented 3 years ago

@bishopb unfortunately this solution also causes an error - Attempt to read property "session" on null (Most recent call first) - /app/vendor/rollbar/rollbar-laravel/src/MonologHandler.php line 62. When I changed package version to my closed pull request in the same environment, then it works, so I'm still unable to use official version instead of my own fork.

bxsx commented 3 years ago

@bishopb unfortunately this solution also causes an error - Attempt to read property "session" on null (Most recent call first) - /app/vendor/rollbar/rollbar-laravel/src/MonologHandler.php line 62. When I changed package version to my closed pull request in the same environment, then it works, so I'm still unable to use official version instead of my own fork.

This seems to be related to #106 which I just merged. Would you mind giving it a try @Lukasz93P ?

Lukasz93P commented 2 years ago

Hi @bxsx, any update here? Can my PR be merged or maybe you have better solution(mentioned above is not worki g) ?

cyrusradfar commented 2 years ago

Wasn't the issue resolved here https://github.com/rollbar/rollbar-php-laravel/issues/85#issuecomment-810717078

Lukasz93P commented 2 years ago

No it jus introduced another issue which I described here https://github.com/rollbar/rollbar-php-laravel/pull/108#issuecomment-940693528 Only working solution is my PR which has been ignored for long long time...

danielmorell commented 2 years ago

@Lukasz93P what version of rollbar/rollbar-laravel are you running?