rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

Missing session data #113

Open Lukasz93P opened 2 years ago

Lukasz93P commented 2 years ago

Hi - https://github.com/rollbar/rollbar-php-laravel/pull/108 I have added one new comment - error which was supposed to be resolved is still there.

Lukasz93P commented 2 years ago

Is anybody there?

bxsx commented 2 years ago

Hi @Lukasz93P

Thanks for reporting it.

For clarification, here's an exception you mentioned in #108: Attempt to read property "session" on null (Most recent call first) - /app/vendor/rollbar/rollbar-laravel/src/MonologHandler.php line 62

I believe this error occurs due to breaking changes in Lumen 8.x. I've just merged #106 which addresses this issue. Would you mind trying the #106 PR (or master branch) to see if this works for you?

Lukasz93P commented 2 years ago

OK @bxsx thanks, give me a few days, I will check if it works for me.

Lukasz93P commented 2 years ago

@bxsx yes it works, but with this solution data is not complete - just look at screen.

Screenshot 2021-11-05 at 22 43 33

Why you are so stubborn with not using solution which I have proposed It solves everything, instead of using something which works you gave me second not complete solution...

bxsx commented 2 years ago

Thanks for the info @Lukasz93P It seems PR #106 has fixed the reported issue, but now we have a new problem.

Your PR #108 seems to fix this, therefore we are going to re-review it now.