rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

feat: add Laravel integration test matrix #115

Closed bishopb closed 2 years ago

bishopb commented 2 years ago

Description of the change

We integrate with Laravel versions 5.5+. The existing tests verify unit functionality with TestBench but has a few caveats. First, it tests the package against the latest version of Laravel on the PHP engine running the test. Second, as written, there was no version constraint for testbench 3, which is the only way to get Laravel 5 tests. Third, the tests do not perform an end to end test of actual logging within a Laravel application. Finally, the tests do not cover Laravel Zero or Lumen (or Nova, for that matter).

The drawback with this architecture is that changes meant to be backwards compatible could only be verified by manually changing composer JSON and, in the case of PHP engine compatibility, by running with engine alternatives. Additionally, if the package had side effects during its logging operation (such as raising a warning), these would not be noticed by the unit tests.

Combined, these drawbacks make forward progress difficult, because they leave dark many potential in-the-field corners we want to see.

This PR adds a Laravel test matrix that covers Laravel 5.5 through Laravel 8 and on supported underlying PHP versions, coordinated to work with the legacy lineages.

Type of change

Related issues

Checklists

Development

Code review

bxsx commented 2 years ago

Why PHP v8 is not supported in the test matrix?