rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

feat: Lumen test matrix #118

Closed bishopb closed 2 years ago

bishopb commented 2 years ago

Description of the change

Adds a test matrix for Lumen, similar to how is done for Laravel in #115. The failures here are all expected, owing to the incorrect handling of session. As a reminder, this pass is meant to document the current state of the integration: later passes will check master against the relevant versions.

Type of change

Related issues

Checklists

Development

Code review

bxsx commented 2 years ago

The failures here are all expected, owing to the incorrect handling of session. As a reminder, this pass is meant to document the current state of the integration: later passes will check master against the relevant versions.

I understand the approach, but I believe that CI should never fail. It would be better to mark failed tests as skipped/ignored and backlog the failed results.