search

rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

Laravel 9 Support #123

Closed joelbutcher closed 2 years ago

joelbutcher commented 2 years ago

Adds Laravel 9 Support to CI actions and composer

jonnott commented 2 years ago

@joelbutcher See https://github.com/rollbar/rollbar-php-laravel/pull/121

cyrusradfar commented 2 years ago

@joelbutcher hi, we're getting someone to review this and follow up. We see you and thank you!

jamesaspence commented 2 years ago

ngl, I'm eagerly watching this PR because laravel 9 support is the only thing holding us back from an upgrade of our API 😂

jonnott commented 2 years ago

ngl, I'm eagerly watching this PR because laravel 9 support is the only thing holding us back from an upgrade of our API 😂

I think that's true for just about every Rollbar customer who uses Laravel!

@cyrusradfar

jonnott commented 2 years ago

@cyrusradfar @joelbutcher @jamesaspence @bishopb

I'm very close now to ditching Rollbar in favour of Bugsnag. They've already updated their package for L9 compatibility, right after L9's launch .. https://github.com/bugsnag/bugsnag-laravel/releases

cyrusradfar commented 2 years ago

@jonnott frankly, I appreciate that things have been slow and you have the right to feel whatever I won't assume you feel that leads you to want to switch.

On this SDK specifically, we've had some turnover in the community of supporters and, therefore, have less resources than I want to help release this. I'm waiting on testing that I feel needs to be done. It slows things down but I'm biasing as a newcomer to this SDK and the company to being more prudent.

Thanks for keeping us accountable.

W.r.t. leaving us, that would be tragic less because of some loss of a customer but you seem to have a voice that can really help me light some 🔥 around here.

Thank you for that and for your support. Either way, you've made an impact and I'm grateful for that.

joelbutcher commented 2 years ago

@cyrusradfar what testing do you think needs to be completed on this before being merged? I can spin up a working Laravel 9 app with routes for logging to rollbar within minutes. If required, I can provide an example repo

s5w95 commented 2 years ago

Quick workaround until they merge this PR

composer.json

"require": {
   ...
  "rollbar/rollbar-laravel": "dev-feature/laravel-9-support",
  ...
},
"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/joelbutcher/rollbar-php-laravel"
        },
],
...

works for me fine on laravel 9

jonnott commented 2 years ago

@cyrusradfar Great. Can we now also merge #93 and then get a new major version tagged asap? The clock is ticking for myself and many others it would seem..

cyrusradfar commented 2 years ago

@jonnott are you impacted by #94?

Based on our review merging #94 would actually be a step backwards. Monolog\Handler\RollbarHandler is the correct reference and Rollbar\Monolog\Handler\RollbarHandler is the old one.

W.r.t tagging a release, we'll do so -- thank you.

jonnott commented 2 years ago

@jonnott are you impacted by #93?

Based on our review merging #93 would actually be a step backwards. Monolog\Handler\RollbarHandler is the correct reference and Rollbar\Monolog\Handler\RollbarHandler is the old one.

W.r.t tagging a release, we'll do so -- thank you.

Sorry, I meant https://github.com/rollbar/rollbar-php-laravel/pull/94 (PR 94) rather than issue 93..

jonnott commented 2 years ago

If https://github.com/rollbar/rollbar-php-laravel/pull/94 doesn't need merging, can the PR be closed?

cyrusradfar commented 2 years ago

Yes, it should be, let me put some explanation there as to why for the folks who've been waiting.

danielmorell commented 2 years ago

@jonnott thank you for keeping on top of things here! We have released v7.1.0 and it includes Laravel 9 support as added by @joelbutcher. We deeply appreciate both of you and your perseverance on this update!