rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

Add support for Rollbar v3 #131

Closed danielmorell closed 2 years ago

danielmorell commented 2 years ago

Description of the change

This PR includes the work of @philsturgeon and @tobigumo.

Any more work required to make this library compatible with rollbar/rollbar v3 will also be rolled up into this PR.

Type of change

Related issues

Checklists

Development

Code review

danielmorell commented 2 years ago

The install step is now working. However, we have a test failure that I did not see locally. I will need to dig into that.

danielmorell commented 2 years ago

I have been able to reproduce the error locally.

PHPUnit 9.5.19 #StandWithUkraine

..F                                                                 3 / 3 (100%)

Time: 00:00.080, Memory: 22.00 MB

There was 1 failure:

1) Tests\Feature\LoggingTest::test_log_call_invokes_rollbar_check_ignore
Rollbar check_ignore handler not invoked, suggesting an issue integrating Rollbar into Laravel.
Failed asserting that file "/.tmp.txt" exists.

/var/www/rollbar/rollbar-test-app/tests/Feature/LoggingTest.php:14

FAILURES!
Tests: 3, Assertions: 3, Failures: 1.

Now, I just need to dig into the cause.