rollbar / rollbar-php-laravel

Rollbar error monitoring integration for Laravel projects
https://docs.rollbar.com/docs/laravel
140 stars 39 forks source link

How is max_items reset since RollbarLogger is set as singleton #139

Open ls-paulo opened 2 years ago

ls-paulo commented 2 years ago

According to the docs, max_items is "Maximum number of items sent in a single app request/response cycle".

The RollbarServiceProvider defines RollbarLogger as a singleton, in which the same instance will be returned on subsequent calls into the container.

Given the above, wouldn't be more appropriate to use scoped instead? As it would do exactly what the Rollbar docs state for max_items config?