Closed michaelscola closed 1 year ago
This is related to #141.
NB @michaelscola Have you seen Monolog's upgrade guide, where it hints at how you'd possibly support multiple Monolog versions (e.g. 2/3) in terms of LogRecord vs array arguments? https://github.com/Seldaek/monolog/blob/main/UPGRADE.md
NB @michaelscola Have you seen Monolog's upgrade guide, where it hints at how you'd possibly support multiple Monolog versions (e.g. 2/3) in terms of LogRecord vs array arguments? https://github.com/Seldaek/monolog/blob/main/UPGRADE.md
I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.
I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.
Sure .. easiest to just target Monolog 3, PHP 8.1, and Laravel 10 then.
I did, but you are going to run into an issue because older PHP versions don't support union types and thus will break our typehinting. So really the only option I see is a BC.
Sure .. easiest to just target Monolog 3, PHP 8.1, and Laravel 10 then.
It does seem like a path of diminishing returns to try and get it working.
@michaelscola See https://github.com/rollbar/rollbar-php/pull/602
We released v4.0.0-rc
of the core rollbar/rollbar
library today! It supports Monolog 3.
@michaelscola Could you bump rollbar/rollbar
to ^4.0
. I also think orchestra/testbench
should be upgraded to v8.
After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing.
I will go ahead and get this updated today.
On Thu, Feb 23, 2023 at 5:43 PM Daniel Morell @.***> wrote:
We released v4.0.0-rc of the core rollbar/rollbar library today! It supports Monolog 3.
@michaelscola https://github.com/michaelscola Could you bump rollbar/rollbar to ^4.0. I also think orchestra/testbench should be upgraded to v8.
After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing.
— Reply to this email directly, view it on GitHub https://github.com/rollbar/rollbar-php-laravel/pull/142#issuecomment-1442578986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7S4J2TJYRRQBDUKJWHRCTWY7YZJANCNFSM6AAAAAAU5BR2VE . You are receiving this because you were mentioned.Message ID: @.***>
We released
v4.0.0-rc
of the corerollbar/rollbar
library today! It supports Monolog 3.@michaelscola Could you bump
rollbar/rollbar
to^4.0
. I also thinkorchestra/testbench
should be upgraded to v8.After that I will make the needed updates to automated test suite, then I think we should be in a position to release a beta version for testing.
This has been completed
I will work on those CI tests this afternoon.
Updated the composer.json file to be inline with Laravel 10 - dropped all PHP support except 8.1 and added illuminate/support 10 only