Our CI tests are failing because composer is trying to only install stable dependencies. Installing rollbar/rollbar-laravel from our a path repository without any version in the composer.json file causes composer to assume its version is dev-master. dev-master has a stability of dev.
To fix this problem I added an arbitrary stable version 1.0.0 to the rollbar/rollbar-laravel package in the test app composer.json file.
The other option would be to change the minimum stability requirement in the test app to dev. However, this could have some unintended side effects if other unstable packages are installed.
The last change is replacing the Try to resolve requirements into an installable set of packages step with the added -W flag on the previous step. It essentially does the same thing but better. This also means we can remove the id and continue-on-error keys.
Type of change
[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Maintenance
[ ] New release
Related issues
None
Checklists
Development
[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
Code review
[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer
Description of the change
Our CI tests are failing because composer is trying to only install stable dependencies. Installing
rollbar/rollbar-laravelfrom our a path repository without any version in thecomposer.jsonfile causes composer to assume its version isdev-master.dev-masterhas a stability ofdev.To fix this problem I added an arbitrary stable version
1.0.0to therollbar/rollbar-laravelpackage in the test appcomposer.jsonfile.The other option would be to change the minimum stability requirement in the test app to
dev. However, this could have some unintended side effects if other unstable packages are installed.The last change is replacing the
Try to resolve requirements into an installable set of packagesstep with the added-Wflag on the previous step. It essentially does the same thing but better. This also means we can remove theidandcontinue-on-errorkeys.Type of change
Related issues
None
Checklists
Development
Code review