It adds missing type annotations and comments explaining the methods and their inputs and outputs. This is a BC because it must be respected by any user created class extending one of these.
It moves the $access_token in our test suite from being a dynamically declared property to being defined on the class for compatibility with PHP 8.2.
Type of change
[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Maintenance
[ ] New release
Related issues
None
Checklists
Development
[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development
Code review
[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer
Description of the change
This PR does two things...
$access_tokenin our test suite from being a dynamically declared property to being defined on the class for compatibility with PHP 8.2.Type of change
Related issues
None
Checklists
Development
Code review