search

rollbar / rollbar-php-wordpress

Official WordPress plugin from Rollbar, Inc.
https://rollbar.com/
GNU General Public License v2.0
15 stars 20 forks source link

don’t start a session for wp-cron #88

Closed andrewminion-luminfire closed 4 years ago

andrewminion-luminfire commented 4 years ago

Possible fix for #85 and #86 Fixes #82

andrewminion-luminfire commented 4 years ago

@ArturMoczulski Any plans to pull this in soon?

ArturMoczulski commented 4 years ago

@andrewminion-luminfire yes. I'm hoping to give the plugin a lot of love in the upcoming weeks. You can expect to be released soon

Lalee10 commented 3 years ago

@ArturMoczulski in our codebase we have version 2.6.1 for this plugin but this change is not there. I see that last version release was on 28 Dec, 2019 but this PR was merged after that. I don't know how releases work but shouldn't the plugin version be updated after every update, so that everyone using the plugin can get these updates?

fliespl commented 2 years ago

@ArturMoczulski I still feel it's better to not use sessions when not needed (as in this case ). admin_notice would be enough here.

It's not only starting sessions causing error on cron - it would also break caching for frontend part (PHPSESS cookie might kill caching mechanism) of the page since it's hooked to "init".

And as far as I remember rollbar-php sdk doesn't require sessions to work.

bishopb commented 2 years ago

Thanks for the follow-up, @fliespl. Indeed, the next major release (3.x) does not start sessions at all. There are a few tiny edge cases for existing WordPress installs that need a bit of massage for the next minor release (2.7), and I'm working through those.

On Mon, Oct 4, 2021 at 2:33 PM fliespl @.***> wrote:

@ArturMoczulski https://github.com/ArturMoczulski I still feel it's better to not use sessions when not needed (as in this case ). admin_notice would be enough here.

It's not only starting sessions causing error on cron - it would also break caching for frontend part (PHPSESS cookie might kill caching mechanism) of the page since it's hooked to "init".

And as far as I remember rollbar-php sdk doesn't require sessions to work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rollbar/rollbar-php-wordpress/pull/88#issuecomment-933747471, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUG54PC75KHHWPMVRKMVUDUFHXQFANCNFSM4JJDLRQA .