Typescript: make type for person.id nullable - Githubissues

rollbar / rollbar.js

Error tracking and logging from Javascript to Rollbar

https://docs.rollbar.com/docs/javascript

MIT License

571 stars 213 forks source link

Typescript: make type for person.id nullable #1074

Closed waltjones closed 1 year ago

waltjones commented 1 year ago

Description of the change

person.id in the Rollbar config should be nullable as documented.

Example:

    payload: {
      person: {
        id: null
      }
    }

This PR makes the Typescript type definition nullable.

Type of change

[x] Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes https://github.com/rollbar/rollbar.js/issues/1058

https://app.shortcut.com/rollbar/story/120519

Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] Issue from task tracker has a link to this pull request
[x] Changes have been reviewed by at least one other engineer