Remove node 8 support - Githubissues

mudetroit commented 11 months ago

Description of the change

Remove support for node 8, and update dependencies as we are able to.

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Maintenance
[ ] New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Fix [SC-127975]
Fix #1

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

shortcut-integration[bot] commented 11 months ago

This pull request has been linked to Shortcut Story #127975: Drop Node 8 support to eliminate a security risk.

mudetroit commented 10 months ago

@waltjones we talked about possibly vendorizing istanbul-instrumenter-loader. I haven't done that yet; because, there were about 3 other packages that still flagged vulnerabilities. I didn't know if it was worth it for the single item or not. Totally open to your opinion there.

waltjones commented 10 months ago

I think removing Node 8 clears the way to upgrade to a newer webpack, karma, etc. and then we don't need this package.

That said, I wouldn't be opposed to vendorizing in the short term. Sooner than later we should update the main build/CI deps.

mudetroit commented 10 months ago

I think removing Node 8 clears the way to upgrade to a newer webpack, karma, etc. and then we don't need this package.

That said, I wouldn't be opposed to vendorizing in the short term. Sooner than later we should update the main build/CI deps.

@waltjones I would agree, how would you feel about splitting the deprecation of Node 8 support from upgrading webpack/karma/etc? Make this the official break leaving us more free to select what the next step is

waltjones commented 10 months ago

splitting the deprecation of Node 8 support from upgrading webpack/karma/etc

👍 Agreed.

rollbar / rollbar.js

Remove node 8 support #1119