rollbar / rollbar.js

Error tracking and logging from Javascript to Rollbar
https://docs.rollbar.com/docs/javascript
MIT License
571 stars 213 forks source link

Don't look for for non-top frame locals in node >=18 during locals tests #1134

Closed matux closed 7 months ago

matux commented 7 months ago

[!IMPORTANT]

Post-merge comment

Locals seem to be available after all but changes in how Node 18 deliver call frames has broken our mechanism to extract these.

This is now a bug, and we should be able to revert these changes once we figure out how to extract locals for Node 18+.

Refer to ticket SC-134017.

Description of the change

This PR fixes a failing test running over false assumptions around node/v8 locals in stack traces.

After careful testing, beginning Node.js 18, it seems locals are only present in top frames. However, I wasn't able to pinpoint documentation about this.

[!NOTE] This PR also updates CI to run installs and tests under lts nodes 14 through latest.

Type of change

Checklists

Development

Code review

shortcut-integration[bot] commented 7 months ago

This pull request has been linked to Shortcut Story #134017: rollbar.js isn't capturing locals except for the top frame.