rollbar / terraform-provider-rollbar

Terraform provider for Rollbar
https://rollbar.com
MIT License
28 stars 13 forks source link

resourceUserDelete does not delete user #226

Closed awendt closed 1 year ago

awendt commented 3 years ago

Hi! 👋🏻

I noticed that deleting the user resource only removed the user from the teams, but not from the account. The implementation of resourceUserDelete is currently:

  1. get user ID
  2. get current teams
  3. remove user from current teams
  4. done

Is it intention that the user resource is not deleted?

GreyOBox commented 3 years ago

@awendt https://github.com/rollbar/terraform-provider-rollbar/pull/231 It has to help

davidji99 commented 3 years ago

@awendt

My take is that rollbar_user should be renamed to something else. The current name implies that I can manage the lifecycle of a user in Rollbar. This is incorrect. rollbar_user initially manages the invitation of a new user and then mainly manages the association/disassociation of a user with a team. However, you cannot update/delete the user, which are actions that I myself expect of a resource named rollbar_user.