rollbar / terraform-provider-rollbar

Terraform provider for Rollbar
https://rollbar.com
MIT License
28 stars 13 forks source link

Add darwin arm64 target #274

Closed jhottenstein closed 2 years ago

jhottenstein commented 2 years ago

Description of the change

Adds arm64 as an architecture for darwin goos

This will make it possible for someone on macos silicon to use this provider

Type of change

Related issues

Resolves #261

Checklists

Development

Code review

jhottenstein commented 2 years ago

Hello,

I don't know much about go or terraform plugin development. Is this sufficient to make a darwin arm64 binary so that I can use your plugin? Happy to modify if I need to do more.

Thanks!

haggishunk commented 2 years ago

Hi @jhottenstein, building for darwin_arm64 will require golang 1.16 at a minimum. Appreciate the effort in making this provider more usable on different platforms!

jhottenstein commented 2 years ago

Hello! Thanks for the reply. I've updated the go version in the module. Anything else?

kyledecot commented 2 years ago

🎉 Thanks for making these changes @jhottenstein

jhottenstein commented 2 years ago

@haggishunk Do I need to do anything? Thanks!

KieranP commented 2 years ago

@haggishunk Are we able to get a release for darwin_arm64? Running terraform init -upgrade, I'm still getting:

Provider registry.terraform.io/rollbar/rollbar v1.5.0 does not have a package available for your current platform, darwin_arm64.

As such, I've been unable to run my terraform scripts for weeks since changing to a new M1 Mac.

cyrusradfar commented 2 years ago

Thanks for the suggestions. Product team will look into prioritizing the update.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: