rollbar / terraform-provider-rollbar

Terraform provider for Rollbar
https://rollbar.com
MIT License
28 stars 13 forks source link

making project access token sensitive #391

Closed pawelsz-rb closed 6 months ago

pawelsz-rb commented 6 months ago

Description of the change

making project access token sensitive. Notice now access token is not displayed to the user in the terraform plan, apply or destroy:

 # rollbar_project_access_token.test_1 will be created
  + resource "rollbar_project_access_token" "test_1" {
      + access_token                = (sensitive value)
      + cur_rate_limit_window_count = (known after apply)
      + cur_rate_limit_window_start = (known after apply)
      + date_created                = (known after apply)
      + date_modified               = (known after apply)
      + id                          = (known after apply)
      + name                        = "test-token-1"
      + project_id                  = 222222222222222222
      + rate_limit_window_count     = 500
      + rate_limit_window_size      = 60
      + scopes                      = [
          + "post_client_item",
        ]
      + status                      = "enabled"
    }

if the users intentionally want to see a sensitive variable, they can use: terraform show --json

Type of change

Related issues

relates to PR #384

Checklists

Development

Code review

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8386010945

Details


Totals Coverage Status
Change from base Build 8170248558: 0.0%
Covered Lines: 1480
Relevant Lines: 1607

💛 - Coveralls
codeclimate[bot] commented 6 months ago

Code Climate has analyzed commit f67f8dd2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.0% (0.0% change).

View more on Code Climate.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: