search

rollbear / trompeloeil

Header only C++14 mocking framework
Boost Software License 1.0
802 stars 85 forks source link

CMake version required not correct #310

Closed Zara-ber closed 10 months ago

Zara-ber commented 1 year ago

Hi In (root)CMakeLists, the CM<KE version required is 3.14, but in test/CMakeLists.txt the version rage to locate Catch is 2..<3, a feature that works only from CMake version 3.19 onwards. Pleasde fix it in first, or make it explicit in second, whihever you think is the better solutiion.

Thanks!

rollbear commented 1 year ago

Good catch. Thank you! Will fix.

rollbear commented 1 year ago

Please check out branch cmake_version and see what you think.

I've changed how you build, so that you need to be explicit about building the tests, by adding -DTROMPELOEIL_BUILD_TESTS=yes to your CMake command line. CMakeLists.txt for the tests explicitly require version 3.19. I've updated the README.

Zara-ber commented 1 year ago

Hi, Now it fails (for me) correctly. Now I will get the newest version of cmake installed and continue. Thanks a lot

rollbear commented 1 year ago

Excellent. I've merged this to main now. Leaving the issue open until a release has been tagged.

rollbear commented 10 months ago

Tagged v46 so closing now. Thanks for reporting and testing.