search

rollerderby / scoreboard

CRG Derby Scoreboard
Other
132 stars 54 forks source link

V2025-Beta1 - Support Portrait orientation in JT Mobile Control #713

Open bullseye555 opened 3 weeks ago

bullseye555 commented 3 weeks ago

Describe the bug When rotating from Landscape to Portrait, the buttons on the JT control don't scale/reposition correctly

To Reproduce Steps to reproduce the behavior:

  1. Open the JT Controls on a mobile device
  2. Orientate to Portrait mode
  3. See the issue
  4. Orientate to Landscape mode
  5. See resolution

Expected behavior When in portrait mode, the buttons scale or reposition as appropriate for a the screen size

Screenshots Landscape: Screenshot_20240617-144419

Portrait: Screenshot_20240617-144416

Version: 2025-beta1

If this issue occurred on a smartphone, tablet, or other device, please complete the following information:

frank-weinberg commented 3 weeks ago

This is a conscious limitation as I couldn't come up with a good layout that works in portrait mode. Suggestions welcome.

bullseye555 commented 3 weeks ago

Noted - I'll have a think and mock something up

On Tue, 18 June 2024, 08:14 frank-weinberg, @.***> wrote:

This is a conscious limitation as I couldn't come up with a good layout that works in portrait mode. Suggestions welcome.

— Reply to this email directly, view it on GitHub https://github.com/rollerderby/scoreboard/issues/713#issuecomment-2174524330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3YNGYDELQXBRXSJCFCD7TZH5NUHAVCNFSM6AAAAABJNK5OKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGUZDIMZTGA . You are receiving this because you authored the thread.Message ID: @.***>