rollerderby / scoreboard

CRG Derby Scoreboard
Other
136 stars 55 forks source link

[BUG] 2025.1_Beta3 PBM view shows no penalties when player is boxed #759

Closed queekusme closed 2 months ago

queekusme commented 2 months ago

Describe the bug I opened the PBM screen to see what the new feature entailed, however the view was unresponsive and only displayed 'Current Penalties' in a red box

To Reproduce Steps to reproduce the behavior:

  1. Initialise a game through standard methods
  2. Open the PBM view seperate to the scoreboard
  3. Lineup a player to box
  4. Start Jam
  5. box the player
  6. See error (also note javascript console)

Expected behavior PBM screen to respond (I am unsure of desired effect due to how new this feature is), current penalties to be shown on the screen.

Screenshots IMG_3447 Screenshot 2024-08-12 at 13 59 36

Version: 2025.1_Beta3

If this issue occurred on a computer, please complete the following information:

Additional context crg-game-2024-08-12__Black_vs.White(Running_16-_8).json

frank-weinberg commented 2 months ago

The PBM screen is just the top part of the PBT screen, intended to be used on a phone strapped to the arm or hand (so the PBM has their hands free o give hand signals to skaters).

So you will only see timers show up there after you start them on the PBT screen. In your Photo, I see a skater marked as penalized but not in the box yet, so no timer on the PBM screen would be expected.

queekusme commented 2 months ago

Ah, I see, as I'm testing solo I can only do so much, might rope some others in to see if we can simulate more roles,

The JS errors are still slightly concerning, however feel free to close if you're happy

frank-weinberg commented 2 months ago

The "failed to load" errors are ok for this screen - it will always try to load the index.js and index.css files but this screen doesn't have either. I'm not sure where exactly the $.widget one is coming from but I get it as well in Chrome and it doesn't appear to affect functionality. My guess is that it is also an artefact of the load errors.

And I get the trouble with trying to do everything alone. That is a struggle at times during development as well.