Improvide internal process

rollerworks-graveyard / RollerworksMultiUserBundle

Multi user management for the FOSUserBundle - DISCONTINUED!!

MIT License

56 stars 21 forks source link

Improvide internal process #60

Open sstok opened 10 years ago

sstok commented 10 years ago

Use UserDIConfig class for configuring UserSystem config in the factory, factory uses less of a state.
- use a configuration builder for configuring (also allows greater flexibility)
- special builder for registering the services

How to keep all the sections clean for UserDIConfig?

I'd rather not add them hardcoded.
Separate class per section, implementing an common interface?

sstok commented 10 years ago

The Rollerworks\Bundle\MultiUserBundle\Model\UserConfig should be an Immutable class which does not know about services. This removes the need for lazy loading (and the proxy class).

For getting access to services we can introduce some like Rollerworks\Bundle\MultiUserBundle\Model\UserSystem.

But this a potential BC break so I'd like to known if any one is depending on the UserConfig for getting the user/group-manager in there code. This should actually be avoided.

sstok commented 10 years ago

I think it should be possible to do this without breaking BC. Mainly the internals will be rewritten, but for applications currently using this we can keep a BC layer.

Now if I only can find the time to work on this...