search

rollerworks / PasswordStrengthBundle

Symfony Password strength and blacklisting validator bundle
MIT License
142 stars 26 forks source link

Use modern php versions #96

Closed vkhramtsov closed 5 years ago

vkhramtsov commented 5 years ago
Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
vkhramtsov commented 5 years ago

@sstok I would like to update minimum requirement for symfony 4 to symfony 4.1 due to https://symfony.com/roadmap/4.1 here and in https://github.com/rollerworks/PasswordStrengthValidator. What do you think about this?

vkhramtsov commented 5 years ago

@sstok Changed configuration of phpstan a little bit. Looks like now this PR is ready for review

sstok commented 5 years ago

Thank you @vkhramtsov

vkhramtsov commented 5 years ago

@sstok No problem. Looks like #95 could be closed as it duplicates this PR