search

rollerworks / search

PHP search-systems made possible
https://rollerworkssearch.readthedocs.io/en/latest/index.html
MIT License
109 stars 17 forks source link

[Feature] Elasticsearch 7 #301

Open jkabat opened 1 year ago

jkabat commented 1 year ago

Any plan to support ruflin/Elastica:^7 any time soon?

jkabat commented 1 year ago

@sstok maybe I could help with this one - do you have any sidenotes which could speed up the process?

sstok commented 1 year ago

I haven't used Elasticsearch myself, I know @dkarlovi did most of the work on this integration. Maybe he can provide some help.

dkarlovi commented 1 year ago

@jkabat please feel free to contribute any fixes and features, I haven't really used this library actively since we last spoke in #268. :+1: Thanks!

jkabat commented 1 year ago

@sstok @dkarlovi my preliminary tests show that by allowing ruflin/Elastica:^7.0 everything works as supposed to.

You are even doing tests using that package and elasticasearch v7: https://github.com/rollerworks/search/blob/v2.0.0-BETA2/composer.json#L53 https://github.com/rollerworks/search/blob/v2.0.0-BETA2/.github/workflows/ci.yaml#L48

It is just not allowed for the single package: https://github.com/rollerworks/search-elasticsearch/blob/v2.0.0-BETA2/composer.json#L26

Right now Im using my fork and testing my implementation against v7. Ill provide feedback and fixes if necessary. Thanks again for the hard work on this library.