rolling-scopes-school / support

15 stars 3 forks source link

Cross-Check 'File Manager' - 'opty1712'. #950

Closed Opty1712 closed 8 months ago

Opty1712 commented 8 months ago
  1. A link to your deployed project

    • no
  2. A link to the project repository on Github.

  3. A link to the task

  4. A Link to the checklist for evaluating the task (if it exists)

  5. A screenshot of cross-checking marks

    image
  6. A final score after self-assessment, with comments 330

  7. A cross-check score of your Score 0

No one made review of my task, I made three :(

haslie22 commented 8 months ago

Basic Scope 234/240

General 16/16

Operations fail 30/30

Navigation & working directory operations 40/40

Basic operations with files 54/60

Operating system info 34/34

Hash calculation 20/20

Compress and decompress operations 40/40

Advanced Scope 90/90

Penalties 0/-413

There are some issues I've encountered while checking the app:

  1. You can have several types of instances besides files or folders, like symbolic links or sockets. You could check for those when executing ls command.
  2. Use .toString() to display end-of-line in os --EOL, because in your current implementation the user can see only a blank line instead of \n or \r\n.
  3. I guess you were supposed to output only the folder name, not the whole path, when running os --homedir.
  4. It would be nice if you implemented the option to compress or decompress files without specifying the output file name, such as compress ./test.txt my-folder. Your current implementation appears too restrictive for the user.

But I don't see any reason to deduct points for these requirements, because all doubts are resolved in favor of the student.

  1. I deducted 6 points for the implementation of the commands cp and mv (3 points for each). The specification states that the usage of these commands should look like this: cp path_to_file path_to_new_directory mv path_to_file path_to_new_directory However, in your implementation, the second argument requires not only the path to the directory but also the name of the new file, which does not fully comply with the specification.

Total: 324/330 points

haslie22 commented 8 months ago

@helenakrasnova take a look please 👀

helenakrasnova commented 8 months ago

@haslie22 you are unicorn of appeals :cherry_blossom:

Opty1712 commented 8 months ago

@haslie22, thank you!

ThorsAngerVaNeT commented 8 months ago

Score was updated