rolling-scopes-school / support

15 stars 3 forks source link

Cross-Check 'File manager' - 'Mat-Kon' #952

Closed Mat-Kon closed 9 months ago

Mat-Kon commented 9 months ago
  1. A link to your deployed project

    • no deployed
  2. A link to the project repository on Github.

  3. A link to the task

  4. A Link to the checklist for evaluating the task (if it exists)

    • I haven't seen the check list
  5. A screenshot of cross-checking marks image

  6. A final score after self-assessment, with comments

    • 330/330 I have completed all the points of the task
  7. A cross-check score of your Score

    • 279 I have one examiner and I disagree with his assessment
helenakrasnova commented 9 months ago

Issue naming should be via rules: Cross-check 'name of task' - 'github'

Mat-Kon commented 9 months ago

I fix this

haslie22 commented 9 months ago

Basic Scope 217/240

General 16/16

Operations fail 20/30

Navigation & working directory operations 40/40

Basic operations with files 60/60

Operating system info 31/34

Hash calculation 20/20

Compress and decompress operations 30/40

Advanced Scope 90/90

Penalties 0/-413

There are some issues I've encountered while checking the app:

  1. You can have several types of instances besides files or folders, like symbolic links or sockets. You could check for those when executing ls command.
  2. When using up command, the display of the current directory does not match the actual directory: the actual directory is one level higher than the one displayed, it becomes clear when you use ls command after each up command.
  3. Use .toString() to display end-of-line in os --EOL, because in your current implementation the user can see only a blank line instead of \n or \r\n.
  4. I guess you were supposed to output only the folder name, not the whole path, when running os --homedir.

But I don't see any reason to deduct points for these requirements, because all doubts are resolved in favor of the student.

  1. I deducted 10 points for the requirement "Operation fail doesn't crash application".
    When I try to start the application with predefined script npm run start or when I don't indicate username (e.g. npm run start -- --username=), the application crashes with the error:
Снимок экрана 2024-02-16 в 00 01 27
  1. I deducted 10 points for the requirement "Decompress file (using Brotli algorithm)" because every attempt to decompress a file, whether successful or not, leads to an error. Here is an example of the error encountered after successful decompression:
Снимок экрана 2024-02-16 в 00 45 12
  1. I also deducted 3 points for the requirement "Get host machine CPUs info (overall amount of CPUs plus model and clock rate (in GHz) for each of them)" , because you don't convert clock rate to GHz, the value your app displays is actually in MHz (1 GHz = 10^3 MHz):
Снимок экрана 2024-02-16 в 00 51 44

Total: 307/330 points

haslie22 commented 9 months ago

@helenakrasnova take a look please 👀

Mat-Kon commented 9 months ago

Thanks, all ok )

ThorsAngerVaNeT commented 9 months ago

Score was updated