rolling-scopes-school / support

15 stars 3 forks source link

Cross-Check 'Simple CRUD AI' - 'garnich'. #958

Closed garnich closed 6 months ago

garnich commented 8 months ago
  1. A link to your deployed project

    • not reqired
  2. A link to the project repository on Github.

  3. A link to the task

  4. A Link to the checklist for evaluating the task (if it exists)

  5. A screenshot of cross-checking marks image

  6. A final score after self-assessment, with comments Self check: 222

After receiving a rating (0) from Reviewer 1, I carried out an additional check and, having found out the reason, deleted the yarn.lock file from the repository (see details in comment on screenshot of cross-checking marks), which made it possible to conduct a normal cross-check (confirmation is the review dated 02/18/2024). Reviewer 1 did not conduct further verification, although he did read the comment I left.

Based on the results of this cross-check, the score was unreasonably reduced by 50%.

  1. A cross-check score of your Score image
helenakrasnova commented 8 months ago

reviewer's contacts should be hidden

garnich commented 8 months ago

@helenakrasnova Updated. image

haslie22 commented 6 months ago

Basic Scope 69/72

When trying to delete user with valid userId, server returns 200 instead of 204.

Would be nice to add smth like .env.example file to the repo.

Advanced Scope 70/70

Hacker Scope 60/80

The load balancer isn't working properly. It fails when handling the userId.
For instance, after adding a user, I can view the list of all users via GET api/users, but I'm unable to retrieve details about a specific user via GET api/users/{userId} or delete it using DELETE api/users/{userId}. Furthermore, the state of the database isn't consistent across different workers; it's only preserved for one worker.

Penalties

Total: 199/222 points

haslie22 commented 6 months ago

@AlreadyBored @ThorsAngerVaNeT take a look please 👀

ThorsAngerVaNeT commented 6 months ago

@AlreadyBored @ThorsAngerVaNeT take a look please 👀

Thank you, Liza. I will update student score

ThorsAngerVaNeT commented 6 months ago

Score is updated