rolling-scopes-school / support

15 stars 3 forks source link

task 2 cross-check score #963

Closed VoliaSi closed 3 months ago

VoliaSi commented 4 months ago
  1. A link to your deployed project https://github.com/VoliaSi/nodejs-aws-shop-react/pull/1 (but it is not very important) - the info is below:

These are two links provided in README: S3 - http://volia-task2-bucket.s3-website-us-east-1.amazonaws.com/ CloudFront - https://d2s2j8ibzo2f3m.cloudfront.net/

This is the link provided to both reviewers on their request after it was found that the working link had stopped working:

d21hvg5oqzabr.cloudfront.net

  1. A link to the project repository on Github. https://github.com/rolling-scopes-school/nodejs-aws-shop-react

  2. A link to the task https://github.com/rolling-scopes-school/aws/blob/main/aws-developer/02_serving_spa/task.md

  3. A Link to the checklist for evaluating the task (if it exists)

  4. A screenshot of cross-checking marks Task2Screenshot

https://app.rs.school/course/student/cross-check-submit?course=aws-developer-2024q2&taskId=3280

  1. A final score after self-assessment, with comments

70 considerig the communication during the review, but not less than 30 - definitely.

I did S3 (30) and CloudFront(40), began the last optional task (30), but left, so didn't expect any considerable score for it.

a) I don't see reasons for giving less than 30 for s3

b) I do not know why, but the working link to Cloudfront stopped working and it really didn't work when I received the review comment, but I provided alternative working link to BOTH reviewers on their request. CaptureReviewConversation

I expected +40 for CloudFront task as official documentation of RS school says that we must ask for a link if the provided one is broken.

But even if people do not communicate, then 403 is definitely more than 0 points as 403 != 404!!! So I think that 0 points for Cloudfront is not fair.

(Also I suspect, that the minimal mark was also considered in calculation - see below).

  1. A cross-check score of your Score

    18

  2. The reaised issues:

a) It is not clear from the task statement how the links should work. If I implement only s3, then there sould be a working link, if I try CloudFront also, s3 must show 403 (as shown in my S3 link), people giving 0 probably expect some content instead of 403.

b) As far as I understand from the provided scores average was calculaed on the base of two given marks, the lowest one was also considered.

c) It is not very clear how to coommunicate. Reviewing other's tasks I also met cases when people just didn't answer me. I had two cases when the name provided in the review was not found by Discord - in such cases it is not clear where and how I can find the person.