Closed guranda26 closed 1 month ago
Please, fix your appeal according to rules: https://docs.rs.school/#/en/cross-check-flow?id=appeal
Hello. is it correct now?
Point Screenshot of the cross-check grades (the reviewers' contact information should be hidden). should be fixed as well Please fix 6 point using markdown syntax properly
Thank you. I have fixed it
Regarding the task points:
Only the seventh point is not done. The button didn't work for me. The ErrorBoundary.tsx is present in the code. There can be a debate about how many out of 10 points should be given for this. I estimate it at half - 5 points.
My total is 94 points. I deduct one point for working in the main branch.
@helenakrasnova could you take a look?
@andron13 thank you!
score is updated
Thank you very much
Score: 94 / 100.
[x] Eslint is set up, when lint command is run it doesn't produce any errors (if there are warnings score might be less) - (15/15)
[x] Prettier is set up, format:fix command fixes issues - (15/15).
[x] Husky is set up, linting is run on pre-commit - (10/10).
[x] Page is split into 2 sections, top one has Search input and "Search" button, main section displays the list of results from the selected api when page is opened for the first time (loader should be shown while app makes a call to the api) - (20/20).
[x] When user types something to the Search input and clicks "Search" button, a loader is displayed and the list is changed according to the response results for a provided search term - (15/15).
[x] The search term typed into the Search input is saved in the LS when user clicks on "Search" button (check it by closing the tab and open the app in the new one - the initial call should contain previously entered search term) - (15/15).
[ ] Application is wrapped with ErrorBoundary, which logs error to a console but doesn't show a fallback UI. There should be a button to throw an error - (6/10).