rolling-scopes-school / support

15 stars 3 forks source link

Cross-Check 'React. Task #1 React project setup. Class components. Error boundary.' 'guranda26' #965

Closed guranda26 closed 1 month ago

guranda26 commented 2 months ago
  1. A link to your deployed project
  2. A link to the project repository on Github.
  3. A link to the task
  4. A Link to the checklist for evaluating the task (if it exists)
  5. A screenshot of cross-checking marks
    • Screenshot
    • Screenshot 1
  6. A final score after self-assessment, with comments.
helenakrasnova commented 1 month ago

Please, fix your appeal according to rules: https://docs.rs.school/#/en/cross-check-flow?id=appeal

guranda26 commented 1 month ago

Hello. is it correct now?

helenakrasnova commented 1 month ago

Point Screenshot of the cross-check grades (the reviewers' contact information should be hidden). should be fixed as well Please fix 6 point using markdown syntax properly

guranda26 commented 1 month ago

Thank you. I have fixed it

andron13 commented 1 month ago
  1. Branch Main should have been clean (only readme and, for example, gitignore) and the work should have started in the task branch.
  2. vite.svg remained in the standard favicon.

Regarding the task points:

  1. [x] Eslint is set up; when the lint command is run, it doesn't produce any errors (if there are warnings, the score might be less).
  2. [x] Prettier is set up; format:fix command fixes issues.
  3. [x] Husky is set up; linting is run on pre-commit.
  4. [x] Page is split into 2 sections.
  5. [x] When the user types something into the Search input and clicks the 'Search' button.
  6. [x] The search term typed into the Search input is saved in the LS.
  7. [ ] Application is wrapped with ErrorBoundary.

Only the seventh point is not done. The button didn't work for me. The ErrorBoundary.tsx is present in the code. There can be a debate about how many out of 10 points should be given for this. I estimate it at half - 5 points.

My total is 94 points. I deduct one point for working in the main branch.

@helenakrasnova could you take a look?

helenakrasnova commented 1 month ago

@andron13 thank you!

helenakrasnova commented 1 month ago

score is updated

guranda26 commented 1 month ago

Thank you very much