search

rolling-scopes / rsschool-app

An application for the RS School education process
https://app.rs.school
Mozilla Public License 2.0
9.89k stars 202 forks source link

Score ranking bug #2479

Open sergiozeppo opened 1 month ago

sergiozeppo commented 1 month ago

Describe the bug There comes a point in every RSS course when students are expelled or they do it on their own. In this case, further study of the remaining students is associated with a bug that does not allow them to know the current position in the ranking.

It leads to consequences like this image

A student will not be able to accurately determine his/her position even if he/she moves to Score. A student will only be able to understand it roughly relative to others whose positions in the ranking are more or less similar to the truth.

Here is the last page rankings, with only 526 students remaining at the time of writing this issue. As you can see, none of them have the correct position. image

This is because the student position number is taken from the overall table and the number of active students is recalculated separately.

To Reproduce Steps to reproduce the behavior:

  1. Go to the JavaScript/Front-end 2023Q4 course, mentioned in this issue
  2. Go to Score
  3. Review that Active Students Only checkbox is ON by default
  4. Go to the last page
  5. Remember the number of students near the navigation panel
  6. Choose the random student to ensure his/her position isn't right
  7. Turn off Active Students Only checkbox
  8. Review that the number of students near the navigation panel increased
  9. Find chosen random student via github/name/etc.
  10. Notify that number of his/her position is not changed
  11. See the bug.

Expected behavior The bug can be fixed (as I think) by recalculating the position numbers relative to condition of Active Students Only checkbox, and respectively to the number of active/inactive students

Device (please complete the following information): This bug is not depend on the device or operating system.

Additional context This bug doesn't just affect students from the last page. Since the mass expulsions, the bug affects students starting from the middle of the table.

AlreadyBored commented 1 week ago

@sergiozeppo this is not a bug, we simply calculate score over all students, not only active, nobody told that position in total score should depend on "Active students only" toggle. However, we will review existing approach and decide whether there's a space for improvement, thank you for your intake anyway :)

sergiozeppo commented 1 week ago

this is not a bug, we simply calculate score over all students, not only active, nobody told that position in total score should depend on "Active students only" toggle.

Thanks for the answer. I didn't spelled it correctrly, of course, it's not a bug. But this is a quite confusing and illogical thing, I guess. And it starts to confuse students right in the dashboard. If you find the time, consider implementing this feature. Thanks in advance!