search

rolling-scopes / site

🦥🛼 Website supporting The Rolling Scopes and The Rolling Scopes School educational process
https://rs.school
13 stars 10 forks source link

613-feat: Update communication section #616

Closed KristiBo closed 1 month ago

KristiBo commented 1 month ago

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Before:

before

After:

after

Added/updated tests?

Summary by CodeRabbit

Release Notes

github-actions[bot] commented 1 month ago

Lighthouse Report:

View detailed report

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces several updates to the communication-related components within the application. A new constant for a Telegram chat link is added, and corresponding properties for English and Russian text are included in the `communicationText` object. The SCSS styles are restructured for better organization, and the tests for the `Communication` component are updated to reflect changes in how elements are selected. Overall, these modifications enhance the handling of communication channels and improve the component's dynamic content rendering. ## Changes | File | Change Summary | |----------------------------------------|-----------------------------------------------------------------------------------------------------| | dev-data/communication.data.ts | Added constant `JS_EN_TELEGRAM_CHAT_LINK` with URL 'https://t.me/RSS_EN' | | dev-data/index.ts | Exported `JS_EN_TELEGRAM_CHAT_LINK` from `./communication.data` | | dev-data/widget-communication.data.ts | Added new properties to `communicationText` for English and Russian sections (8 properties total) | | src/widgets/communication/ui/*.scss | Restructured SCSS for `.communication-content`, removed `.communication-paragraph`, nested classes | | src/widgets/communication/ui/communication.test.tsx | Updated test to use `screen.getByTestId('discord-link')` for selecting Discord link element | | src/widgets/communication/ui/communication.tsx | Added constant `JS_EN_TELEGRAM_CHAT_LINK`, updated rendering logic, and added new properties to `communicationText` | ## Assessment against linked issues | Objective | Addressed | Explanation | |--------------------------------------------------------------------------|-----------|-----------------------------------------| | Update text and links to include both Discord and Telegram (#[613]) | ✅ | | | Modify `communicationText` for English JavaScript course (#[613]) | ✅ | | ## Possibly related PRs - **#536**: Introduced a new `communicationText` object with localized text, relevant to the Telegram link addition. - **#605**: Added a `discordNote` property to the `communicationText`, directly related to the updates in communication links. ## Suggested reviewers - dzmitry-varabei - andron13 - natanchik - SpaNb4 - ansivgit
📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between 993144488a56a01e32421e3e383da57d6fc2a90d and 3b6f5dac9ea0fa5b7fd868c9290c19cdb6858fa2.
📒 Files selected for processing (2) * dev-data/widget-communication.data.ts (2 hunks) * src/widgets/communication/ui/communication.tsx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * dev-data/widget-communication.data.ts * src/widgets/communication/ui/communication.tsx
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 month ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 1 month ago

Lighthouse Report:

View detailed report