search

rolling-scopes / site

🦥🛼 Website supporting The Rolling Scopes and The Rolling Scopes School educational process
https://rs.school
13 stars 10 forks source link

Feat/552 rs app courses integration #633

Closed Quiddlee closed 1 week ago

Quiddlee commented 2 weeks ago

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

gif

Summary by CodeRabbit

Release Notes

github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces several changes to enhance the handling of course data within the application. Key modifications include the addition of an `API_URL` environment variable for API access, updates to various workflow files to utilize this variable, and significant refactoring of course-related components to support asynchronous data fetching. The overall structure of the course data management is improved by integrating constants for course titles and aliases, and by replacing hardcoded values with dynamic references. ## Changes | File Path | Change Summary | |------------------------------------------------|-------------------------------------------------------------------------------------------------------------| | `.env.example` | Added new environment variable `API_URL`. | | `.github/workflows/*.yml` | Added `API_URL` environment variable to build steps in CI workflows. | | `.gitignore` | Added `.env` to ignore list. | | `dev-data/courses.data.ts` | Added `alias` property to course objects and updated `startDate` to `TO_BE_DETERMINED`. | | `env.d.ts` | Added `API_URL` to `ProcessEnv` interface. | | `package.json` | Updated `lint` and `lint:fix` scripts to increase `--max-warnings` from 400 to 500. | | `src/app/courses/*.tsx` | Updated various components to handle asynchronous data fetching and modified function signatures accordingly. | | `src/core/base-layout/*.tsx` | Refactored `BaseLayout` and `Footer` components to support asynchronous data fetching. | | `src/entities/course/api/course-api.ts` | Introduced `getCourses` function for asynchronous course data retrieval with caching. | | `src/entities/course/constants.ts` | Added constants `ALIAS_QUARTER_REGEXP` and `COURSE_DATE_FORMAT`. | | `src/entities/course/types.ts` | Modified course-related types to include new properties and imports. | | `src/shared/constants.ts` | Added constants `TO_BE_DETERMINED` and `COURSE_ALIASES`. | | `src/shared/helpers/*.ts` | Updated various helper functions to use new constants and handle asynchronous operations. | | `src/widgets/*.tsx` | Updated various widgets to utilize new course data structure and asynchronous fetching. | | `tsconfig.json` | Added `env.d.ts` to the TypeScript compilation include list. | ## Assessment against linked issues | Objective | Addressed | Explanation | |------------------------------------------------------------------|-----------|-----------------------------------| | Synchronization of course information with RS APP (#552) | ✅ | | | Integration with RS APP to synchronize course data (#404) | ✅ | | ## Suggested labels `high priority` ## Suggested reviewers - dzmitry-varabei - andron13 - natanchik - SpaNb4 - KristiBo

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
src/shared/constants.ts Oops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-boundaries". (The package "eslint-plugin-boundaries" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: npm install eslint-plugin-boundaries@latest --save-dev The plugin "eslint-plugin-boundaries" was referenced from the config file in " » @feature-sliced/eslint-config » /node_modules/@feature-sliced/eslint-config/rules/layers-slices". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 2 weeks ago

Lighthouse Report:

View detailed report

github-actions[bot] commented 1 week ago

Lighthouse Report:

View detailed report