rolling-scopes / site

🦥🛼 Website supporting The Rolling Scopes and The Rolling Scopes School educational process
https://rs.school
13 stars 10 forks source link

480-refactor: Remove css prefixes #655

Open Quiddlee opened 1 week ago

Quiddlee commented 1 week ago

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions[bot] commented 4 days ago

Lighthouse Report:

View detailed report

Quiddlee commented 4 days ago

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46 PM
SpaNb4 commented 4 days ago

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46 PM

Are you sure this is coming from stylelint and not your ide?

Quiddlee commented 4 days ago

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46 PM

Are you sure this is coming from stylelint and not your ide?

it's using stylelint from node_modules and i believe configuration file from our project too

Screenshot 2024-11-21 at 11 55 30 PM
Quiddlee commented 4 days ago

Should we also consider adding this rule? https://stylelint.io/user-guide/rules/property-no-vendor-prefix/

This rule is already applied

Screenshot 2024-11-21 at 10 53 46 PM

Are you sure this is coming from stylelint and not your ide?

it's using stylelint from node_modules and i believe configuration file from our project too

Screenshot 2024-11-21 at 11 55 30 PM

it's somehow doesn't work if i use npm run stylelint even when explicitly define this rule

Screenshot 2024-11-22 at 12 06 33 AM
SpaNb4 commented 12 hours ago

it's somehow doesn't work if i use npm run stylelint even when explicitly define this rule

that's weird, but okay image