rollingrock / Fallout-4-VR-Body

Developing mod to add full body support with IK for Fallout 4 VR!
MIT License
45 stars 8 forks source link

Helmet and Eyewear do not hide in Frik 66 when hide_head is enabled #52

Closed alandtse closed 5 months ago

alandtse commented 5 months ago

When hide head is enabled, the helmet/eyewear are now clearly visible above the player.

This is caused by changes to Skeleton.cpp setBodyPosture introduced by https://github.com/rollingrock/Fallout-4-VR-Body/commit/addf5241847049a57ce909da1c43606cc004e656#diff-4657ee9a4c06e6bf95d38ebf2bf2cab004bd3ac7228054de644a0b8ecd5c83ffL1050-L1131.

Specifically, the early return; was removed which enables a previously disabled section. . https://github.com/rollingrock/Fallout-4-VR-Body/commit/addf5241847049a57ce909da1c43606cc004e656#diff-4657ee9a4c06e6bf95d38ebf2bf2cab004bd3ac7228054de644a0b8ecd5c83ffL1105

The head is being correctly moved up by:

        com->m_localTransform.pos.z = newPos.z;

The changes in skeleton.cpp for setBodyPose now put the head much higher than it was before. This makes any thing on the head more obvious when you look up.

Note, hide head option never hid the helmet/goggles before, but it wasn't as noticeable since you were inside the head gear and it was being clipped by VR's closeness clipping. You would occasionally see some goggle clippage from a strange angle but it wasn't too obvious (strange clippage is due to #53). You can see the issue easiest in selfie mode. The head is much lower but basically in your HMD visor.