search

rollkit / avail-da

Apache License 2.0
20 stars 7 forks source link

fix(ci): handle empty ids case to avoid panics #17

Closed MSevey closed 9 months ago

MSevey commented 9 months ago

Overview

Resolve panic seen in CI

--> Running unit tests
=== RUN   TestAvailDA
=== RUN   TestAvailDA/Basic_DA_test
    test_suite.go:40: 
            Error Trace:    /home/runner/work/avail-da/avail-da/test/test_suite.go:40
                                        /home/runner/work/avail-da/avail-da/test/test_suite.go:16
            Error:          Received unexpected error:
                            Post "http://localhost:9000/v2/submit": dial tcp [::1]:9000: connect: connection refused
            Test:           TestAvailDA/Basic_DA_test
--- FAIL: TestAvailDA (0.00s)
    --- FAIL: TestAvailDA/Basic_DA_test (0.00s)
panic: runtime error: index out of range [0] with length 0 [recovered]
    panic: runtime error: index out of range [0] with length 0

goroutine 34 [running]:
testing.tRunner.func1.2({0x94ad80, 0xc0001ac030})
    /opt/hostedtoolcache/go/1.21.6/x64/src/testing/testing.go:1545 +0x3f7
testing.tRunner.func1()
    /opt/hostedtoolcache/go/1.21.6/x64/src/testing/testing.go:1548 +0x716
panic({0x94ad80?, 0xc0001ac030?})
    /opt/hostedtoolcache/go/1.21.6/x64/src/runtime/panic.go:920 +0x270
github.com/rollkit/avail-da/test.BasicDATest(0xc000057e80?, {0xa20070, 0xc00006ac00})
    /home/runner/work/avail-da/avail-da/test/test_suite.go:45 +0xd79
github.com/rollkit/avail-da/test.RunDATestSuite.func1(0x0?)
    /home/runner/work/avail-da/avail-da/test/test_suite.go:16 +0x45
testing.tRunner(0xc00019a000, 0xc000180000)
    /opt/hostedtoolcache/go/1.21.6/x64/src/testing/testing.go:1595 +0x262
created by testing.(*T).Run in goroutine 6
    /opt/hostedtoolcache/go/1.21.6/x64/src/testing/testing.go:1648 +0x846
FAIL    github.com/rollkit/avail-da 0.019s
?       github.com/rollkit/avail-da/cmd/avail-da    [no test files]
Mock Server is running on :9000

Checklist

Summary by CodeRabbit

coderabbitai[bot] commented 9 months ago

Walkthrough

This update introduces additional validation checks within a test suite, specifically focusing on verifying the lengths of two sets of identifiers and their corresponding proofs. This enhancement aims to ensure that the data adheres to expected length constraints, improving the robustness and reliability of the testing process.

Changes

File Change Summary
test/test_suite.go Added assertions for length validation of id1, proof1, id2, and proof2.

🐇✨
In the land of code, where the tests do leap,
A rabbit hopped in, making checks not weak.
With a twitch of its nose, and a flick of its ear,
Ensured id and proof lengths, crystal clear.
So hop we now, with joy and cheer,
For robust tests, the rabbit holds dear.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
codecov[bot] commented 9 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (471cf84) 33.33% compared to head (6522eda) 32.97%. Report is 6 commits behind head on main.

:exclamation: Current head 6522eda differs from pull request most recent head cd311ce. Consider uploading reports for the commit cd311ce to get more accurate results

Files Patch % Lines
test/test_suite.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================== - Coverage 33.33% 32.97% -0.36% ========================================== Files 3 3 Lines 372 376 +4 ========================================== Hits 124 124 - Misses 231 235 +4 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.