search

rollno748 / di-kafkameter

JMeter Plugin to load test Apache Kafka topics/brokers
34 stars 11 forks source link

Wrong default StringDeserializer instead of StringSerializer fixed in KafkaProducerConfigBeanInfo plus error handling fixed #11

Closed giraone closed 1 year ago

giraone commented 1 year ago

The default for key and value serialize were wrong in KafkaProducerConfigBeanInfo. It was org.apache.kafka.common.serialization.StringDeserializer instead of org.apache.kafka.common.serialization.StringSerializer.

I also fixed the Kafka client creation. The error message was passed to the logger (Log Viewer in JMeter), but the cause and stack trace to stderr.

rollno748 commented 1 year ago

Hi Thanks for bringing this up Appreciate your time in making a pull request to fix it.

Yes Indeed, its a wrong default value for serializer class on producer and consumer config. Can you submit the change for KafkaConsumerConfigBeanInfo.java as well, so that I can merge this ?

giraone commented 1 year ago

The consumer config is OK. Consumers must deserialze, producer must serialize.The 2nd change was related to error handling.Am 12.02.2023 12:30 schrieb Mohamed Ibrahim @.***>: Hi Thanks for bringing this up Appreciate your time in making a pull request to fix it. Yes Indeed, its a wrong default value for serializer class on producer and consumer config. Can you submit the change for KafkaConsumerConfigBeanInfo.java as well, so that I can merge this ?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>