Closed rollsroyc3 closed 7 years ago
Go ahead and retry (pull latest master).
Looks like some issues with retain. If any of these fixes will take a while please let me know first.
https://www.dropbox.com/s/04716obnxrjzqkj/Screenshot%202017-01-17%2017.03.12.png?dl=0
Oh for some reason I thought this project was not using ARC. Just a sec…
On Jan 17, 2017, at 23:04, Andrew Royce notifications@github.com wrote:
Looks like some issues with retain. If any of these fixes will take a while please let me know first.
https://www.dropbox.com/s/04716obnxrjzqkj/Screenshot%202017-01-17%2017.03.12.png?dl=0 https://www.dropbox.com/s/04716obnxrjzqkj/Screenshot%202017-01-17%2017.03.12.png?dl=0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rollsroyc3/opentok-titanium/issues/2#issuecomment-273314846, or mute the thread https://github.com/notifications/unsubscribe-auth/AALjpeCdsm1VXou6C4t6tHJt-CfA2ofqks5rTTrogaJpZM4LmMYW.
Ready again. Pull latest.
Note: the whole thing is still under one hour so far. :)
On Jan 17, 2017, at 23:04, Andrew Royce notifications@github.com wrote:
Looks like some issues with retain. If any of these fixes will take a while please let me know first.
https://www.dropbox.com/s/04716obnxrjzqkj/Screenshot%202017-01-17%2017.03.12.png?dl=0 https://www.dropbox.com/s/04716obnxrjzqkj/Screenshot%202017-01-17%2017.03.12.png?dl=0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rollsroyc3/opentok-titanium/issues/2#issuecomment-273314846, or mute the thread https://github.com/notifications/unsubscribe-auth/AALjpeCdsm1VXou6C4t6tHJt-CfA2ofqks5rTTrogaJpZM4LmMYW.
Wth. A double hash. fixed :)
On Jan 17, 2017, at 23:12, Andrew Royce notifications@github.com wrote:
Getting closer!
https://www.dropbox.com/s/b3lr84yk68g6ru6/Screenshot%202017-01-17%2017.12.06.png?dl=0 https://www.dropbox.com/s/b3lr84yk68g6ru6/Screenshot%202017-01-17%2017.12.06.png?dl=0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rollsroyc3/opentok-titanium/issues/2#issuecomment-273316976, or mute the thread https://github.com/notifications/unsubscribe-auth/AALjpRMEcDyZWLl28DithY4OmoYnQfA0ks5rTTy_gaJpZM4LmMYW.
Compiles! I will be testing tomorrow and will keep you updated. Thanks for the quick work!
@billdawson Log output when trying to compile:
In file included from /Users/andrewroyce/Documents/projects/opentok-titanium/ios/Classes/ComTokboxTiOpentokPublisherProxy.m:7: /Users/andrewroyce/Documents/projects/opentok-titanium/ios/Classes/ComTokboxTiOpentokSessionProxy.h:54:18: error: expected ';' after method prototype
Image if that is easier: https://www.dropbox.com/s/5i0yysyx2mj5cfn/Screenshot%202017-01-17%2016.37.09.png?dl=0