Add rollup-plugin-svg-import

rollup / awesome

⚡️ Delightful Rollup Plugins, Packages, and Resources

MIT License

2.55k stars 139 forks source link

Add rollup-plugin-svg-import #42

Closed korywka closed 4 years ago

korywka commented 4 years ago

Awesome Contribution Checklist:

[x] I have read, and re-read the Contributing Guidelines
[x] I have searched to ensure the suggested item doesn't exist on this list
[x] This PR contains only one item

Please Provide a Link A Repository for Your Addition

https://github.com/bravecow/rollup-plugin-svg-import

Please Describe Your Addition

Imports SVG files as DOM Nodes using DOMParser(). Used and tested for 2 months by mapbox-gl-controls.

shellscape commented 4 years ago

I'm sorry but we cannot accept your submission at this time.

Reason: no tests. https://github.com/rollup/awesome/blob/master/.github/CONTRIBUTING.md#plugin-and-package-guidelines

The first checkbox asks folks to read and re-read the contributing guidelines so items like this are not missed. Please pay closer attention to contribution guidelines for repositories in the future.

korywka commented 4 years ago

No problem. I took as example official plugin for images: https://github.com/rollup/rollup-plugin-image Which is missing tests too 🤷‍♀

shellscape commented 4 years ago

That repo has been deprecated and that plugin has moved to here: https://github.com/rollup/plugins/tree/master/packages/image. And it does have tests now :) All core plugins were migrated to that repo and tests were added where there were none.