rollup / awesome

⚡️ Delightful Rollup Plugins, Packages, and Resources
MIT License
2.55k stars 139 forks source link

add: hoist-import-deps #67

Closed vikerman closed 3 years ago

vikerman commented 4 years ago

Awesome Contribution Checklist:

Please Provide a Link A Repository for Your Addition

https://github.com/vikerman/rollup-plugin-hoist-import-deps

Please Describe Your Addition

When a module is dynamically imported, it's static imports in turn are loaded after the dynamic import is downloaded and parsed. This causes a delay when doing dynamic imports especially with slow/high latency connections. This plugin changes the dynamic import call site to also add(hoist) the static imports of the module being loaded so that the dynamically imported module and it's dependencies are loaded in parallel instead of in two steps.

shellscape commented 4 years ago

If you read the guidelines, you'd know why this is being closed.

vikerman commented 4 years ago

Sorry. I'm not sure. Thanks for your time.

shellscape commented 4 years ago

It's literally the very first bullet point:

If you just created something, wait at least 30 days before submitting. This is to give it some time to mature and ensure it's not just a publish-and-forget type of project.

vikerman commented 4 years ago

Once again - I'm sincerely sorry if I'm being dumb. Definitely not trying to be malicious.

First version published on May 18th(>30 days) (And have been fixing issues since then and felt good about the current state)

I thought that was sufficient for satisfying the first point.

shellscape commented 4 years ago

Welp. This one is my fault. I'm not sure why, but the second page of commits on your repo was not available when I first looked at it. It appeared as if your project was only 27 days old.

The apology is owed by me. My apologies.

vikerman commented 4 years ago

Phew - Thanks. Glad that's sorted. Please let me know if I should adjust anything else.

vikerman commented 4 years ago

Hi - Please let me know if anything else needs to be done from my side here. Thanks.

shellscape commented 3 years ago

thanks!