search

rollup / awesome

⚡️ Delightful Rollup Plugins, Packages, and Resources
MIT License
2.55k stars 139 forks source link

Add deno-rollup #79

Closed cmorten closed 3 years ago

cmorten commented 3 years ago

Awesome Contribution Checklist:

Please Provide a Link A Repository for Your Addition

https://github.com/cmorten/deno-rollup

Please Describe Your Addition

deno-rollup ports Rollup so it can be used within Deno scripts to bundle modules.

render1613311890881

shellscape commented 3 years ago

Thanks for the PR. One question - is this a fork (or contain source copies/modifications) or a wrapper of Rollup?

cmorten commented 3 years ago

This is a wrapper of the Rollup browser export which is then fleshed out to provide the same ( / as similar as can reasonably achieve ) JavaScript API and CLI.

In order to fill in parts of the interface that are not included in the browser export, there have been some source copies / modifications included in the module.

shellscape commented 3 years ago

In order to fill in parts of the interface that are not included in the browser export, there have been some source copies / modifications included in the module.

No worries. I would like to see a copy of Rollup's license in the repo given that there are copies and mods of original source in there. (It's the right thing to do)

cmorten commented 3 years ago

Ah@shellscape I very much agree, not only as the right thing to do, but also the requirement under MIT licensing - which is why the license has been present in the repo from the initial commit, available in the root under https://github.com/cmorten/deno-rollup/blob/main/ROLLUP_LICENSE.md, referenced in the README.md in the license section ( REF: https://github.com/cmorten/deno-rollup/#license ) and I have endeavoured to also link back specific files to their "original" counterparts so it is apparent in the source code what is a derived work versus new 😄

Please advise if you are expecting anything else with regards to licensing?

shellscape commented 3 years ago

Totally missed that, my fault there. I went straight to LICENSE. I'm perhaps too used to seeing multiple licenses packed into that file.

shellscape commented 3 years ago

thanks!