rollup / plugins

🍣 The one-stop shop for official Rollup plugins
MIT License
3.57k stars 568 forks source link

Add recommendation for tsconfig.json with TypeScript 5+ #1638

Closed berniegp closed 1 month ago

berniegp commented 7 months ago

Rollup Plugin Name: @rollup/plugin-typescript

This PR contains:

Are tests included?

Breaking Changes?

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

As far as I can see, the new bundler option is perfect for use with Rollup, but it would be great for someone else to have a look. It took me a long time to figure out the correct options to use with Node 16 and TS 5+ so I hope that this recommendation will help others.

Also I'm not sure if there should be extra tests to test this configuration.

shellscape commented 7 months ago

Thanks for the PR. While I think this is good info, it doesn't look suited to the readme for the typescript plugin. If you're up for it, I would suggest creating a packages/typescript/recipes/file-extensions.md file that contained a more verbose description of the setup.

berniegp commented 7 months ago

I can have a look at that time permitting. You're referring to the "tsconfig.json recommendations" section to move to another page right?

Should I modify my branch to remove that part so the other changes can be merged?

shellscape commented 6 months ago

Yes that's correct. Since the bulk of the other changes are a change of Typescript -> TypeScript, I'd recommend just making all changes before we merge anything.

shellscape commented 1 month ago

Closing as abandoned.